<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> <span class="fn">Jason Ekstrand</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - VkRunner tests assert when run with nir test environment variables"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108957">bug 108957</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - VkRunner tests assert when run with nir test environment variables"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108957#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - VkRunner tests assert when run with nir test environment variables"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108957">bug 108957</a>
from <span class="vcard"><a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> <span class="fn">Jason Ekstrand</span></a>
</span></b>
<pre>Fixed by the following two commits in master:
commit fe2fc30cb559f7ef99c07bd219c057b011242cb4
Author: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>>
Date: Tue Jun 4 17:50:22 2019 -0500
nir: Don't replace the nir_shader when NIR_TEST_SERIALIZE=1
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - VkRunner tests assert when run with nir test environment variables"
href="show_bug.cgi?id=108957">https://bugs.freedesktop.org/show_bug.cgi?id=108957</a>
Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
Reviewed-by: Rob Clark <<a href="mailto:robdclark@chromium.org">robdclark@chromium.org</a>>
commit 9eba6d9a880558c89a72cbafd873d4fe1247928d
Author: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>>
Date: Tue Jun 4 17:48:33 2019 -0500
nir: Don't replace the nir_shader when NIR_TEST_CLONE=1
Instead, we add a new helper which stomps one nir_shader and replaces it
with another. The new helper effectively just changes which pointer
gets used for the base nir_shader. It should be 99% as good at testing
cloning but without requiring that everything handle having the shader
swapped out from under it constantly.
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - VkRunner tests assert when run with nir test environment variables"
href="show_bug.cgi?id=108957">https://bugs.freedesktop.org/show_bug.cgi?id=108957</a>
Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
Reviewed-by: Rob Clark <<a href="mailto:robdclark@chromium.org">robdclark@chromium.org</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>