<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:denys.kostin@globallogic.com" title="Denis <denys.kostin@globallogic.com>"> <span class="fn">Denis</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - ANGLE BlitFramebufferTest.MultisampleDepthClear/ES3_OpenGL fails on Intel Ubuntu19.04"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111113">bug 111113</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>bisected
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - ANGLE BlitFramebufferTest.MultisampleDepthClear/ES3_OpenGL fails on Intel Ubuntu19.04"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111113#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - ANGLE BlitFramebufferTest.MultisampleDepthClear/ES3_OpenGL fails on Intel Ubuntu19.04"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111113">bug 111113</a>
from <span class="vcard"><a class="email" href="mailto:denys.kostin@globallogic.com" title="Denis <denys.kostin@globallogic.com>"> <span class="fn">Denis</span></a>
</span></b>
<pre>Here is a bisected commit:
0ae9ce0f29ea1973b850a4e6c6cae8606973036e is the first bad commit
commit 0ae9ce0f29ea1973b850a4e6c6cae8606973036e
Author: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>>
Date: Sat Aug 19 20:31:03 2017 -0700
i965/clear: Quantize the depth clear value based on the format
In f9fd976e8adba733b08d we changed the clear value to be stored as an
isl_color_value. This had the side-effect same clear value check is now
happening directly between the f32[0] field of the isl_color_value and
ctx->Depth.Clear. This isn't what we want for two reasons. One is that
the comparison happens in floating point even for Z16 and Z24 formats.
Worse than that, ctx->Depth.Clear is a double so, even for 32-bit float
formats, we were comparing as doubles and not floats. This means that
the test basically always fails for anything other than 0.0f and 1.0f.
This caused a slight performance regression in Lightsmark 2008 because
it was using a depth clear value of 0.999 which can't be stored in a
32-bit float so we were doing unneeded resolves.
Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
Bugzilla: <a href="https://bugs.freedesktop.org/101678">https://bugs.freedesktop.org/101678</a>
Cc: "17.2" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>>
src/mesa/drivers/dri/i965/brw_clear.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
And here is a fix which should fix an issue:
<a href="https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1329">https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1329</a>
As an original patch was related to benchmark, maybe it makes sense to re-run
that bench one more time (current patch was tested on our CI branch)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>