<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [bisected][skl] Graphical corruption in kwin effects"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111499#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [bisected][skl] Graphical corruption in kwin effects"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111499">bug 111499</a>
from <span class="vcard"><a class="email" href="mailto:mike@fireburn.co.uk" title="Mike Lothian <mike@fireburn.co.uk>"> <span class="fn">Mike Lothian</span></a>
</span></b>
<pre>I reverted 246eebba4a8da9c9f4b2b7b98b83c116832dc410 "iris: Export and import
surfaces with modifiers that have aux data" and the new asert happens in the
revert commit
7d4ea1a162a (Jason Ekstrand 2018-10-25 17:02:56 -0500 905) if
(templ->target == PIPE_BUFFER) {
47d4ea1a162a (Jason Ekstrand 2018-10-25 17:02:56 -0500 906)
res->surf.tiling = ISL_TILING_LINEAR;
47d4ea1a162a (Jason Ekstrand 2018-10-25 17:02:56 -0500 907) } else {
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 908) UNUSED
const bool isl_surf_created_successfully =
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 909)
isl_surf_init(&screen->isl_dev, &res->surf,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 910)
.dim = target_to_isl_surf_dim(templ->target),
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 911)
.format = fmt.fmt,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 912)
.width = templ->width0,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 913)
.height = templ->height0,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 914)
.depth = templ->depth0,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 915)
.levels = templ->last_level + 1,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 916)
.array_len = templ->array_size,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 917)
.samples = MAX2(templ->nr_samples, 1),
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 918)
.min_alignment_B = 0,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 919)
.row_pitch_B = whandle->stride,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 920)
.usage = isl_usage,
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 921)
.tiling_flags = 1 << res->mod_info->tiling);
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 922)
assert(isl_surf_created_successfully);
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 923)
assert(res->bo->tiling_mode ==
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 924)
isl_tiling_to_i915_tiling(res->surf.tiling));
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 925)
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 926) // XXX:
create_ccs_buf_for_image?
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 927) if
(!iris_resource_alloc_separate_aux(screen, res))
d13be86f07ae (Mike Lothian 2019-09-15 17:02:35 +0100 928) goto
fail;
47d4ea1a162a (Jason Ekstrand 2018-10-25 17:02:56 -0500 929) }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>