[Bug 47941] [snb] Backlight control broken between 3.6.0-rc1 and 3.6.0-rc4

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=47941





--- Comment #21 from Takashi Iwai <tiwai at suse.de>  2012-12-08 08:08:03 ---
Hm, the commit above just shuffles the order of three register writes.
What happens if you add the lines back like the patch below, i.e. calling
intel_panel_actually_set_backlight() twice, before and after setting two
registers?

diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers/gpu/drm/i915/intel_panel.c
index e2aacd3..7e82b0b 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -320,6 +320,9 @@ void intel_panel_enable_backlight(struct drm_device *dev,
     if (dev_priv->backlight_level == 0)
         dev_priv->backlight_level = intel_panel_get_max_backlight(dev);

+    dev_priv->backlight_enabled = true;
+    intel_panel_actually_set_backlight(dev, dev_priv->backlight_level);
+
     if (INTEL_INFO(dev)->gen >= 4) {
         uint32_t reg, tmp;

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.