[Bug 54687] [ilk] pipe off timeout

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Dec 11 15:16:20 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=54687

--- Comment #4 from Daniel Vetter <daniel at ffwll.ch> ---
Checking the modeset sequence again, we're supposed to disable pch outputs
_after_ having disable the cpu pipe, but before disabling pch transcoder stuff
and the fdi link. I.e.

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 82267b2..6b2b8a8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3490,9 +3490,6 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc)
        if (!intel_crtc->active)
                return;

-       for_each_encoder_on_crtc(dev, crtc, encoder)
-               encoder->disable(encoder);
-
        intel_crtc_wait_for_pending_flips(crtc);
        drm_vblank_off(dev, pipe);
        intel_crtc_update_cursor(crtc, false);
@@ -3509,6 +3506,9 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc)
        I915_WRITE(PF_WIN_SZ(pipe), 0);

        for_each_encoder_on_crtc(dev, crtc, encoder)
+               encoder->disable(encoder);
+
+       for_each_encoder_on_crtc(dev, crtc, encoder)
                if (encoder->post_disable)
                        encoder->post_disable(encoder);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20121211/3e5d3c2d/attachment.html>


More information about the intel-gfx-bugs mailing list