[Bug 68716] [SNA][HSW] Dragging windows in Gnome3 overview is less smooth than with UXA

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68716

--- Comment #13 from Chris Wilson <chris at chris-wilson.co.uk> ---
Slightly less nasty is:

commit c32b7fa40bac264f847ece54ef1fab69179950b9
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Aug 30 02:04:55 2013 +0100

    always boost

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2f9ff14..2f72420 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1126,8 +1126,13 @@ static int __wait_seqno(struct intel_ring_buffer *ring,
u32 seqno,

     timeout_jiffies = timeout ? timespec_to_jiffies_timeout(timeout) : 1;

-    if (dev_priv->info->gen >= 6 && can_wait_boost(file_priv))
+    if (dev_priv->info->gen >= 6 && can_wait_boost(file_priv)) {
         gen6_rps_boost(dev_priv);
+        if (file_priv)
+            mod_delayed_work(dev_priv->wq,
+                     &file_priv->mm.idle_work,
+                     msecs_to_jiffies(100));
+    }

     if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring)) &&
         WARN_ON(!ring->irq_get(ring)))
@@ -2226,8 +2231,6 @@ int __i915_add_request(struct intel_ring_buffer *ring,
     if (file) {
         struct drm_i915_file_private *file_priv = file->driver_priv;

-        cancel_delayed_work_sync(&file_priv->mm.idle_work);
-
         spin_lock(&file_priv->mm.lock);
         request->file_priv = file_priv;
         list_add_tail(&request->client_list,
@@ -2265,10 +2268,6 @@ i915_gem_request_remove_from_client(struct
drm_i915_gem_request *request)

     spin_lock(&file_priv->mm.lock);
     list_del(&request->client_list);
-    if (list_empty(&file_priv->mm.request_list))
-        mod_delayed_work(to_i915(request->ring->dev)->wq,
-                 &file_priv->mm.idle_work,
-                 msecs_to_jiffies(100));
     request->file_priv = NULL;
     spin_unlock(&file_priv->mm.lock);
 }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130830/6c866bc1/attachment-0001.html>