[Bug 66752] New: GCC version check in sna/compiler.h is incorrect

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66752

          Priority: medium
            Bug ID: 66752
          Assignee: chris at chris-wilson.co.uk
           Summary: GCC version check in sna/compiler.h is incorrect
        QA Contact: intel-gfx-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: thomas.jones at utoronto.ca
          Hardware: Other
            Status: NEW
           Version: git
         Component: Driver/intel
           Product: xorg

The following is causing compile errors for me because gcc 4.5 does not have
the -Ofast option

#if HAS_GCC(4, 5) && defined(__OPTIMIZE__)
#define fast_memcpy __attribute__((optimize("Ofast")))
__attribute__((target("inline-all-stringops")))
#else
#define fast_memcpy
#endif

It could be corrected if this is done instead

#if HAS_GCC(4, 6) && defined(__OPTIMIZE__)
#define fast_memcpy __attribute__((optimize("Ofast")))
__attribute__((target("inline-all-stringops")))
#if HAS_GCC(4, 5) && defined(__OPTIMIZE__)
#define fast_memcpy __attribute__((target("inline-all-stringops")))
#else
#define fast_memcpy
#endif

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130710/4ca8b7be/attachment.html>