[Bug 66077] Oops reading i915_error_state

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66077

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit c7815d42dfce7439cde3f23766e7dea59ffa7e1a
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Sat Jun 29 23:26:50 2013 +0100

    drm/i915: Break up the large vsnprintf() in print_error_buffers()

    So it appears that I have encountered some bogosity when trying to call
    i915_error_printf() with many arguments from print_error_buffers(). The
    symptom is that the vsnprintf parser tries to interpret an integer arg
    as a character string, the resulting OOPS indicating stack corruption.
    Replacing the single call with its 13 format specifiers and arguments
    with multiple calls to i915_error_printf() worked fine. This patch goes
    one step further and introduced i915_error_puts() to pass the strings
    simply.

    It may not fix the root cause, but it does prevent my box from dying and
    I think helps make print_error_buffers() more friendly.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66077
    Cc: Mika Kuoppala <mika.kuoppala at intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130630/ac2a4813/attachment.html>