[Bug 62343] Incorrect image in vlc if non-default crop factor is selected (XVideo).

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=62343

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Chris Wilson <chris at chris-wilson.co.uk> ---
Thanks, I was little disturbed because I thought I had fixed it for 2.21.4. As
it turns out the fix was missing a vital little cast to avoid an integer
division:

commit 94cb10c3f2b9bbb6ae3c76faebe9fc88691224a9
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Mar 14 22:02:09 2013 +0000

    sna/gen5+: Add missing float casts in computation of scaled src offsets

    Without the casts, the division ends up as 0 rather than the fractional
    offset into the texture.

    The casts were missed in the claimed fix:

    commit 89038ddb96aabc4bc1f04402b2aca0ce546e8bf3
    Author: Chris Wilson <chris at chris-wilson.co.uk>
    Date:   Thu Feb 28 14:35:54 2013 +0000

        sna/video: Correct scaling of source offsets

    Reported-by: Roman Elshin <roman.elshin at gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=62343
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130314/8de1481b/attachment.html>