[Bug 71605] 2.99.906 causes XOrg to die quite frequently

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71605

--- Comment #18 from Jay Little <jaylittle at jaylittle.com> ---
I will provide that momentarily ;)  Note: I'm switching between drivers so that
my laptop will remain at least somewhat useable during this process.

This code in the patch looked a bit odd:

-        size = 3*kgem->aperture_fenced;
-        if (kgem->aperture_total == kgem->aperture_mappable)
-            size += kgem->aperture;
-        if (size > kgem->aperture_mappable &&
-            kgem_ring_is_idle(kgem, kgem->ring))
-            return false;
+        if (kgem->aperture_fenced) {
+            size = 3*kgem->aperture_fenced;
+            if (kgem->aperture_total == kgem->aperture_mappable)
+                size += kgem->aperture;
+            if (size > kgem->aperture_mappable &&
+                kgem_ring_is_idle(kgem, kgem->ring)) {
+                DBG(("%s: opportunistic fence flush\n", __FUNCTION__));
+                return false;
+            }
+        }

         size = kgem->aperture_fenced;

It almost feels like that last line ought to have been deleted. Prior to this
revision if execution got here and kgem->aperture_fenced == 0 then I'm guessing
"return false" would've been executed.  In this revision this situation would
be allowed to continue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20131114/425dd871/attachment.html>