[Bug 59321] S4 broken with Haswell

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=59321

--- Comment #29 from Takashi Iwai <tiwai at suse.de> ---
As Paulo already confirmed, the first patch alone seems working.  With the
first patch, more than 100 S4 cycles with net and proc loads survived and never
crashed.  Great! \o/

With the second patch, there is no visible change, neither WARN nor DRM_ERROR.

Feel free to take my tested-by tags when submitting to upstream:
  Tested-by: Takashi Iwai <tiwai at suse.de>

(In reply to Ben Widawsky from comment #28)
> (In reply to Takashi Iwai from comment #27)
> > BTW what are the magic registers 0x4194 and 0x2050?  Are they available no
> > matter which GPU generation?
> 
> 0x4194 has existed for some time. It's just hardcoded as a quick hack since
> all the experiments with Paulo shows the render ring causing issue. See
> #define RING_FAULT_REG(ring)    (0x4094 + 0x100*(ring)->id) in
> drivers/gpu/drm/i915/i915_reg.h

Thanks for the pointer.

> I'm not sure how long 0x2050 has been in the HW. It's a register which is
> meant for debug purposes only, and let's just say it's magic for now (you
> can figure out from the code what it should be telling us).

OK, I was just curious because the functions are applied globally to all chips.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.