[Bug 70764] [snb] TearFree now triggers stuck semaphores (due to Eliminate the synchronous wait from inside TearFree)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 23 13:52:55 CEST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=70764

--- Comment #13 from Chris Wilson <chris at chris-wilson.co.uk> ---
One last thing you can test is:

diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 7fcade6..1ae9ec0 100644
--- a/src/sna/sna_display.c
+++ b/src/sna/sna_display.c
@@ -4303,12 +4303,14 @@ static bool wait_for_shadow(struct sna *sna, struct
sna_pixmap *priv, unsigned f
                sna_mode_wakeup(sna);

        if (sna->mode.shadow_flip) {
-               bo = kgem_create_2d(&sna->kgem,
-                                   pixmap->drawable.width,
-                                   pixmap->drawable.height,
-                                   pixmap->drawable.bitsPerPixel,
-                                   priv->gpu_bo->tiling,
-                                   CREATE_EXACT | CREATE_SCANOUT);
+               bo = NULL;
+               if (0)
+                       bo = kgem_create_2d(&sna->kgem,
+                                           pixmap->drawable.width,
+                                           pixmap->drawable.height,
+                                           pixmap->drawable.bitsPerPixel,
+                                           priv->gpu_bo->tiling,
+                                           CREATE_EXACT | CREATE_SCANOUT);
                if (bo != NULL) {
                        DBG(("%s: replacing still-attached GPU bo\n",
                             __FUNCTION__));

applied to 

commit b70390b4f824afeed8f1b5a9baf79e33377405cd
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Oct 23 11:15:28 2013 +0100

    sna: Reset bo after allocation failure during wait-for-shadow

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20131023/52ab9aef/attachment-0001.html>


More information about the intel-gfx-bugs mailing list