[Bug 69119] [hsw] WAIT_FOR_EVENT hangs (full screen vsync on pipe 1 with BCS)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69119

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GPU hangs during full       |[hsw] WAIT_FOR_EVENT hangs
                   |screen games on             |(full screen vsync on pipe
                   |multi-monitor setup         |1 with BCS)

--- Comment #8 from Chris Wilson <chris at chris-wilson.co.uk> ---
And to be extra safe, do the check before incrementing the batch pointer:

diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index be02a78..6a5241a 100644
--- a/src/sna/sna_display.c
+++ b/src/sna/sna_display.c
@@ -3392,6 +3392,14 @@ static bool sna_emit_wait_for_scanline_hsw(struct sna
*sna,
        b = kgem_get_batch(&sna->kgem);
        sna->kgem.nbatch += 5;

+       /* Reduce the range slightly to accommodate some latency
+        * in detection: https://bugs.freedesktop.org/show_bug.cgi?id=69119
+        */
+       y1 = (y1 + 7) & ~7;
+       y2 = (y2 - 7) & ~7;
+       if (y2 <= y1)
+               return false;
+
        /* The documentation says that the LOAD_SCAN_LINES command
         * always comes in pairs. Don't ask me why. */
        switch (pipe) {

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130909/46c714c3/attachment.html>