[Bug 76671] [PNV/ILK Regression]X will be no response when run all piglit cases

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Apr 11 03:49:21 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=76671

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 349a1b45a80e5f1dcd8a94516c71118350f439e5
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Apr 9 09:07:36 2014 +0100

    drm/i915: Always use kref tracking for all contexts.

    If we always initialize kref for the context, even if we are using fake
    contexts for hangstats when there is no hw support, we can forgo the
    dance to dereference the ctx->obj and inspect whether we are permitted
    to use kref inside i915_gem_context_reference() and _unreference().

    My ulterior motive here is to improve the debugging of a use-after-free
    of ctx->obj. This patch avoids the dereference here and instead forces
    the assertion checks associated with kref.

    v2: Refactor the fake contexts to being even more like the real
    contexts, so that there is much less duplicated and special case code.

    v3: Tweaks.
    v4: Tweaks, minor.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76671
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Tested-by: lu hua <huax.lu at intel.com>
    Cc: Ben Widawsky <benjamin.widawsky at intel.com>
    Cc: Mika Kuoppala <mika.kuoppala at intel.com>
    Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
    [Jani: tiny change to backport to drm-intel-fixes.]
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140411/6d0cf62c/attachment.html>


More information about the intel-gfx-bugs mailing list