[Bug 77351] [855GM] Mouse cursors show wrong default black cursors and/or do not update correctly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77351

--- Comment #18 from Chris Wilson <chris at chris-wilson.co.uk> ---
Spotted the bug:

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3d017f5b656a..261fc7196e57 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7776,13 +7776,14 @@ static int intel_crtc_cursor_set(struct drm_crtc *crtc,

                addr = i915_gem_obj_ggtt_offset(obj);
        } else {
-               int align = IS_I830(dev) ? 16 * 1024 : 256;
-               ret = i915_gem_attach_phys_object(dev, obj,
-                                                 (intel_crtc->pipe == 0) ?
I915_GEM_PHYS_CURSOR_0 : I915_GEM_PHYS_CURSOR_1,
-                                                 align);
-               if (ret) {
-                       DRM_DEBUG_KMS("failed to attach phys object\n");
-                       goto fail_locked;
+               if (obj->phys_obj == NULL) {
+                       ret = i915_gem_attach_phys_object(dev, obj,
+                                                         (intel_crtc->pipe ==
0) ? I915_GEM_PHYS_CURSOR_0 : I915_GEM_PHYS_CURSOR_1,
+                                                         IS_I830(dev) ? 16 *
1024 : 256);
+                       if (ret) {
+                               DRM_DEBUG_KMS("failed to attach phys
object\n");
+                               goto fail_locked;
+                       }
                }
                addr = obj->phys_obj->handle->busaddr;
        }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140417/0dabe898/attachment-0001.html>