[Bug 77717] [PNV/ILK Regression]igt/drv_suspend/debugfs-reader fails

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 29 01:30:34 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77717

Guo Jinxian <jinxianx.guo at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #3 from Guo Jinxian <jinxianx.guo at intel.com> ---
691e6415c891b8b2b082a120b896b443531c4d45 is the first bad commit
commit 691e6415c891b8b2b082a120b896b443531c4d45
Author:     Chris Wilson <chris at chris-wilson.co.uk>
AuthorDate: Wed Apr 9 09:07:36 2014 +0100
Commit:     Jani Nikula <jani.nikula at intel.com>
CommitDate: Fri Apr 11 13:29:51 2014 +0300

    drm/i915: Always use kref tracking for all contexts.

    If we always initialize kref for the context, even if we are using fake
    contexts for hangstats when there is no hw support, we can forgo the
    dance to dereference the ctx->obj and inspect whether we are permitted
    to use kref inside i915_gem_context_reference() and _unreference().

    My ulterior motive here is to improve the debugging of a use-after-free
    of ctx->obj. This patch avoids the dereference here and instead forces
    the assertion checks associated with kref.

    v2: Refactor the fake contexts to being even more like the real
    contexts, so that there is much less duplicated and special case code.

    v3: Tweaks.
    v4: Tweaks, minor.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76671
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Tested-by: lu hua <huax.lu at intel.com>
    Cc: Ben Widawsky <benjamin.widawsky at intel.com>
    Cc: Mika Kuoppala <mika.kuoppala at intel.com>
    Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
    [Jani: tiny change to backport to drm-intel-fixes.]
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>

:040000 040000 b9a776bb2de3ba84f614087619e9e91a2bdcc960
e5dd0a22c4ec8df198400605e960f8c683e732ed M      drivers

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140429/53a899ad/attachment-0001.html>


More information about the intel-gfx-bugs mailing list