[Bug 78135] New: vblank interrupts lost over suspend & resume

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78135

          Priority: medium
            Bug ID: 78135
                CC: intel-gfx-bugs at lists.freedesktop.org
          Assignee: intel-gfx-bugs at lists.freedesktop.org
           Summary: vblank interrupts lost over suspend & resume
        QA Contact: intel-gfx-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: chris at chris-wilson.co.uk
          Hardware: Other
            Status: NEW
           Version: XOrg CVS
         Component: DRM/Intel
           Product: DRI

42772ff8bd4d26c52b3a79ca02adcccd5d0668d4 is the first bad commit
commit 42772ff8bd4d26c52b3a79ca02adcccd5d0668d4
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date:   Tue Apr 29 13:35:46 2014 +0300

    drm/i915: Make sprite updates atomic

    Add a mechanism by which we can evade the leading edge of vblank. This
    guarantees that no two sprite register writes will straddle on either
    side of the vblank start, and that means all the writes will be latched
    together in one atomic operation.

    We do the vblank evade by checking the scanline counter, and if it's too
    close to the start of vblank (too close has been hardcoded to 100usec
    for now), we will wait for the vblank start to pass. In order to
    eliminate random delayes from the rest of the system, we operate with
    interrupts disabled, except when waiting for the vblank obviously.

    Note that we now go digging through pipe_to_crtc_mapping[] in the
    vblank interrupt handler, which is a bit dangerous since we set up
    interrupts before the crtcs. However in this case since it's the vblank
    interrupt, we don't actually unmask it until some piece of code
    requests it.

    v2: preempt_check_resched() calls after local_irq_enable() (Jesse)
        Hook up the vblank irq stuff on BDW as well
    v3: Pass intel_crtc instead of drm_crtc (Daniel)
        Warn if crtc.mutex isn't locked (Daniel)
        Add an explicit compiler barrier and document the barriers (Daniel)
        Note the irq vs. modeset setup madness in the commit message (Daniel)
    v4: Use prepare_to_wait() & co. directly and eliminate vbl_received
    v5: Refactor intel_pipe_handle_vblank() vs. drm_handle_vblank() (Chris)
        Check for min/max scanline <= 0 (Chris)
        Don't call intel_pipe_update_end() if start failed totally (Chris)
        Check that the vblank counters match on both sides of the critical
        section (Chris)
    v6: Fix atomic update for interlaced modes
    v7: Reorder code for better readability (Chris)
    v8: Drop preempt_check_resched(). It's not available to modules
        anymore and isn't even needed unless we ourselves cause
        a wakeup needing reschedule while interrupts are off

    Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
    Reviewed-by: Sourab Gupta <sourabgupta at gmail.com>
    Reviewed-by: Akash Goel <akash.goels at gmail.com>
    Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140430/b8f8af70/attachment.html>