[Bug 86962] [HSW/BDW Regression]igt/kms_flip/vblank-vs-hang causes system hang

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Dec 5 12:43:13 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=86962

Daniel Vetter <daniel at ffwll.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Daniel Vetter <daniel at ffwll.ch> ---
commit f4cbb3a5f707ae4155beaf103adf50351f6509a0
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Fri Dec 5 13:49:34 2014 +0000

    drm/i915: Zero fill the request structure

    There is a general theory that kzmalloc is better/safer than kmalloc,
especially
    for interesting data structures. This change updates the request structure
    allocation to be zero filled.

    This also fixes crashes in the reset code. Quoting Mika's patch:

    "Clean the request structure on alloc. Otherwise we might end up
    referencing uninitialized fields.  This is apparent when we try to
    cleanup the preallocated request on ring reset, before any request has
    been submitted to the ring.  The request->ctx is foobar and we end up
    freeing the foobarness."

    Note that this fixes a regression introduced in

    commit 9eba5d4a1d79d5094321469479b4dbe418f60110
    Author: John Harrison <John.C.Harrison at Intel.com>
    Date:   Mon Nov 24 18:49:23 2014 +0000

        drm/i915: Ensure OLS & PLR are always in sync

    References: https://bugs.freedesktop.org/show_bug.cgi?id=86959
    References: https://bugs.freedesktop.org/show_bug.cgi?id=86962
    References: https://bugs.freedesktop.org/show_bug.cgi?id=86992
    Change-Id: I68715ef758025fab8db763941ef63bf60d7031e2
    For: VIZ-4377
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Thomas Daniel <Thomas.Daniel at intel.com>
    Cc: Mika Kuoppala <mika.kuoppala at intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20141205/c1c977a2/attachment-0001.html>


More information about the intel-gfx-bugs mailing list