[Bug 87888] New: Bashisms in intel_gpu_abrt script

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Dec 30 18:20:39 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=87888

            Bug ID: 87888
           Summary: Bashisms in intel_gpu_abrt script
           Product: DRI
           Version: unspecified
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/Intel
          Assignee: intel-gfx-bugs at lists.freedesktop.org
          Reporter: vincentc1208 at gmail.com
        QA Contact: intel-gfx-bugs at lists.freedesktop.org
                CC: intel-gfx-bugs at lists.freedesktop.org

intel-gpu-tools ships a #!/bin/sh script that has bash-specific syntax (which
breaks on distros such as Debian and Ubuntu where /bin/sh is a symlink to
something other than bash). Here's a small patch which fixes this. Thanks for
considering!

(Forwarded from 

diff -Nru a/tools/intel_gpu_abrt b/tools/intel_gpu_abrt
--- a/tools/intel_gpu_abrt    2013-02-19 18:05:47.000000000 -0800
+++ b/tools/intel_gpu_abrt    2014-12-30 17:12:56.499574747 -0800
@@ -1,6 +1,6 @@
 #!/bin/sh

-if [[ $UID -ne 0 ]]; then
+if [ $(id -ru) -ne 0 ]; then
     echo "$0 must be run as root"
     exit 1
 fi

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20141231/1875fba1/attachment.html>


More information about the intel-gfx-bugs mailing list