[Bug 74882] [ilk] Corrupted glyph rendering of Stylish entry in Firefox Add-ons tab

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74882

--- Comment #5 from Coacher <itumaykin at gmail.com> ---
(In reply to comment #4)
> That's a little scary. How about
> 
> diff --git a/src/sna/gen5_render.c b/src/sna/gen5_render.c
> index a9db697..0755fd2 100644
> --- a/src/sna/gen5_render.c
> +++ b/src/sna/gen5_render.c
> @@ -54,7 +54,7 @@
>  #define DBG_NO_STATE_CACHE 0
>  #define DBG_NO_SURFACE_CACHE 0
>  
> -#define ALWAYS_FLUSH 0
> +#define ALWAYS_FLUSH 1
>  
>  #define MAX_3D_SIZE 8192
>  
> @@ -1049,7 +1049,7 @@ gen5_emit_state(struct sna *sna,
>         }
>         gen5_emit_vertex_elements(sna, op);
>  
> -       if (kgem_bo_is_dirty(op->src.bo) || kgem_bo_is_dirty(op->mask.bo)) {
> +       if (ALWAYS_FLUSH || kgem_bo_is_dirty(op->src.bo) ||
> kgem_bo_is_dirty(op->mask.bo)) {
>                 DBG(("%s: flushing dirty (%d, %d)\n", __FUNCTION__,
>                      kgem_bo_is_dirty(op->src.bo),
>                      kgem_bo_is_dirty(op->mask.bo)));
> @@ -1058,7 +1058,7 @@ gen5_emit_state(struct sna *sna,
>                 kgem_bo_mark_dirty(op->dst.bo);
>                 flush = false;
>         }
> -       if (flush || ALWAYS_FLUSH) {
> +       if (flush) {
>                 DBG(("%s: forcing flush\n", __FUNCTION__));
>                 gen5_emit_pipe_flush(sna);
> 
> instead?
> 
> i.e. enable ALWAYS_FLUSH and use it to force the full flush rather than the
> pipeline flush.

Part of this patch is already in git isn't it? Should I pull latest changes and
simply switch ALWAYS_FLUSH to 1 then?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140212/8b18266c/attachment.html>