[Bug 70839] [IVB] Undocking laptop causes warning in intel_dp_link_down+0x1d2/0x210

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 30 12:32:00 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=70839

--- Comment #11 from Yuly Novikov <ynovikov at chromium.org> ---
Ah, sorry that I was looking in a wrong branch.
Indeed, the commit in question will remove the warning, as it removes the call
to intel_dp_link_down() from intel_dp_check_link_status().
However, my understanding is that this call was there to support cases where
userspace doesn't handle uevents, and removing it will leave DP link on and
consuming power in such systems, and probably lead to errors when one monitor
is plugged out and another is plugged in. Hope you are keeping track of this in
some other bug.
But, for me the problem is fixed, so you can close this one.

BTW, if relying on uevents is the direction you want to proceed with, I think
you can remove intel_dp_hot_plug() altogether, since currently it does nothing
in case of unplug, and in case of plug, the dp link will be enabled in
intel_enable_dp() anyway, when userspace decides to DPMS_ON.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140130/bd38f24a/attachment.html>


More information about the intel-gfx-bugs mailing list