[Bug 79992] Transient corruption in some applications (regression)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79992

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
Ah. I see something wrong in that patch indeed, try:

diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c
index 13fe6ed..ce04ca0 100644
--- a/src/sna/sna_accel.c
+++ b/src/sna/sna_accel.c
@@ -14382,16 +14382,15 @@ sna_poly_fill_rect(DrawablePtr draw, GCPtr gc, int n,
xRectangle *rect)
                        RegionTranslate(&region, dx, dy);
                }

-               if (region_subsumes_drawable(&region, &pixmap->drawable)) {
-                       discard_cpu_damage(sna, priv);
-                       hint |= IGNORE_CPU | REPLACES;
-               } else {
-                       if ((flags & 2) == 0)
-                               hint |= IGNORE_CPU;
-                       if (priv->cpu_damage &&
-                           region_subsumes_damage(&region, priv->cpu_damage))
{
+               if ((flags & 2) == 0) {
+                       hint |= IGNORE_CPU;
+                       if (region_subsumes_drawable(&region,
&pixmap->drawable)) {
                                discard_cpu_damage(sna, priv);
-                               hint |= IGNORE_CPU;
+                               hint |= REPLACES;
+                       } else {
+                               if (priv->cpu_damage &&
+                                   region_subsumes_damage(&region,
priv->cpu_damage))
+                                       discard_cpu_damage(sna, priv);
                        }
                }
                if (priv->cpu_damage == NULL) {

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140613/4d7f6e80/attachment.html>