[Bug 78494] [uxa regression] [drm:i915_gem_do_execbuffer] 0 cliprects but dirt in cliprects fields

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78494

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit ea2ffaa17220ff906355465a878f019cc7091003
Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date:   Tue May 13 13:37:37 2014 +0200

    drm/i915: Work-around garbage DR4 from UXA

    Somehow UXA submits a completely bogus DR4 value since essentially
    forever. It was originally introduced in

    commit bade7d7d2505a10a8a7d24b084aff9742e2d6d64
    Author: Eric Anholt <eric at anholt.net>
    Date:   Fri Jun 6 14:03:25 2008 -0700

        Use the DRM for submitting batchbuffers when available.

    and dutifully copied around ever since. Since we want to keep the
    general dirt catching around just special case the UXA value.

    This regression was introduced in

    commit 9cb346648d9c529eccc5c7f30093e82d37004e37
    Author: Daniel Vetter <daniel.vetter at ffwll.ch>
    Date:   Thu Apr 24 08:09:11 2014 +0200

        drm/i915: Catch dirt in unused execbuffer fields

    Comment from Chris' review:

    "To be fair, it is a sensible value if one supposes a Region style API to
    cliprects. Under that API, DR[14] define the extents of the clip region,
    and ((0,0), (0,0)) [DR1==DR4==0] would mean all clipped, do not draw
    anything."

    v2: Pimp commit message a bit and remove the double space.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78494
    Cc: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Jörg Otte <jrg.otte at gmail.com>
    Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140513/b1ccde8c/attachment.html>