[Bug 78932] [BDW]igt/kms_flip subcases bo-too-big-interruptible and bo-too-big cause system hang

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78932

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 19656430a874132a1d79c56387a6eec1ef9a5689
Author: Oscar Mateo <oscar.mateo at intel.com>
Date:   Fri May 16 14:20:43 2014 +0100

    drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

    Otherwise, we do a NULL pointer dereference.

    I've seen this happen while handling an error in
    i915_gem_object_pin_to_display_plane():

    If i915_gem_object_set_cache_level() fails, we call is_pin_display()
    to handle the error. At this point, the object is still not pinned
    to GGTT and maybe not even bound, so we have to check before we
    dereference its GGTT vma.

    The IGT kms_flip/bo-too-big tests for this bug.

    v2: Chris Wilson says restoring the old value is easier, but that
    is_pin_display is useful as a theory of operation. Take the solomonic
    decision: at least this way is_pin_display is a little more robust
    (until Chris can kill it off).

    v3: Chris suggests the WARN in i915_gem_obj_to_ggtt has outlived its
    usefulness: add a reminder to remove it.

    Issue: VIZ-3772
    Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
    Testcase: igt/kms_flip/bo-too-big
    Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140520/69ee2c45/attachment-0001.html>