[Bug 81832] [BYT/BDW/BSW Bisected] igt/gem_userptr_blits/swapping-normal-sync cases long time to execute

Tue Sep 2 01:52:19 PDT 2014

https://bugs.freedesktop.org/show_bug.cgi?id=81832

Guo Jinxian <jinxianx.guo at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[BYT/BDW/BSW]               |[BYT/BDW/BSW Bisected]
                   |igt/gem_userptr_blits/swapp |igt/gem_userptr_blits/swapp
                   |ing-normal-sync cases long  |ing-normal-sync cases long
                   |time to execute             |time to execute
           Keywords|bisect_pending              |

--- Comment #3 from Guo Jinxian <jinxianx.guo at intel.com> ---
5cc9ed4b9a7ac579362ccebac67f7a4cdb36de06 is the first bad commit
Author:     Mika Kuoppala <mika.kuoppala at linux.intel.com>
AuthorDate: Fri May 16 13:44:12 2014 +0300
Commit:     Daniel Vetter <daniel.vetter at ffwll.ch>
CommitDate: Fri May 16 16:28:56 2014 +0200

    drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl

    By exporting the ability to map user address and inserting PTEs
    representing their backing pages into the GTT, we can exploit UMA in order
    to utilize normal application data as a texture source or even as a
    render target (depending upon the capabilities of the chipset). This has
    a number of uses, with zero-copy downloads to the GPU and efficient
    readback making the intermixed streaming of CPU and GPU operations
    fairly efficient. This ability has many widespread implications from
    faster rendering of client-side software rasterisers (chromium),
    mitigation of stalls due to read back (firefox) and to faster pipelining
    of texture data (such as pixel buffer objects in GL or data blobs in CL).

    v2: Compile with CONFIG_MMU_NOTIFIER
    v3: We can sleep while performing invalidate-range, which we can utilise
    to drop our page references prior to the kernel manipulating the vma
    (for either discard or cloning) and so protect normal users.
    v4: Only run the invalidate notifier if the range intercepts the bo.
    v5: Prevent userspace from attempting to GTT mmap non-page aligned buffers
    v6: Recheck after reacquire mutex for lost mmu.
    v7: Fix implicit padding of ioctl struct by rounding to next 64bit
boundary.
    v8: Fix rebasing error after forwarding porting the back port.
    v9: Limit the userptr to page aligned entries. We now expect userspace
        to handle all the offset-in-page adjustments itself.
    v10: Prevent vma from being copied across fork to avoid issues with cow.
    v11: Drop vma behaviour changes -- locking is nigh on impossible.
         Use a worker to load user pages to avoid lock inversions.
    v12: Use get_task_mm()/mmput() for correct refcounting of mm.
    v13: Use a worker to release the mmu_notifier to avoid lock inversion
    v14: Decouple mmu_notifier from struct_mutex using a custom mmu_notifer
         with its own locking and tree of objects for each mm/mmu_notifier.
    v15: Prevent overlapping userptr objects, and invalidate all objects
         within the mmu_notifier range
    v16: Fix a typo for iterating over multiple objects in the range and
         rearrange error path to destroy the mmu_notifier locklessly.
         Also close a race between invalidate_range and the get_pages_worker.
    v17: Close a race between get_pages_worker/invalidate_range and fresh
         allocations of the same userptr range - and notice that
         struct_mutex was presumed to be held when during creation it wasn't.
    v18: Sigh. Fix the refactor of st_set_pages() to allocate enough memory
         for the struct sg_table and to clear it before reporting an error.
    v19: Always error out on read-only userptr requests as we don't have the
         hardware infrastructure to support them at the moment.
    v20: Refuse to implement read-only support until we have the required
         infrastructure - but reserve the bit in flags for future use.
    v21: use_mm() is not required for get_user_pages(). It is only meant to
         be used to fix up the kernel thread's current->mm for use with
         copy_user().
    v22: Use sg_alloc_table_from_pages for that chunky feeling
    v23: Export a function for sanity checking dma-buf rather than encode
         userptr details elsewhere, and clean up comments based on
         suggestions by Bradley.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
    Cc: "Gong, Zhipeng" <zhipeng.gong at intel.com>
    Cc: Akash Goel <akash.goel at intel.com>
    Cc: "Volkin, Bradley D" <bradley.d.volkin at intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
    Reviewed-by: Brad Volkin <bradley.d.volkin at intel.com>
    [danvet: Frob ioctl allocation to pick the next one - will cause a bit
    of fuss with create2 apparently, but such are the rules.]
    [danvet2: oops, forgot to git add after manual patch application]
    [danvet3: Appease sparse.]
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

:040000 040000 7bb913fcb031477acbd3e9f994cbc24771c979fa
c1f1ca986ce04f935817b3ae43f0266bec4dd289 M      drivers
:040000 040000 f41358f6ef0f41344941b899c1b53fa8a4fd6fd4
95df53cf81f5b5dda6af773a518cb3e8031b12b7 M      include

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140902/dca9ef11/attachment.html>