[Bug 81410] [BDW Bisected]igt/kms_universal_plane/universal-plane-pipe-A-functional fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=81410

Guo Jinxian <jinxianx.guo at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[BDW                        |[BDW
                   |Regression]igt/kms_universa |Bisected]igt/kms_universal_
                   |l_plane/universal-plane-pip |plane/universal-plane-pipe-
                   |e-A-functional fails        |A-functional fails

--- Comment #5 from Guo Jinxian <jinxianx.guo at intel.com> ---
ab60c84d87edffe6555fc9f1703e8f9074d06416 is the first bad commit.

commit ab60c84d87edffe6555fc9f1703e8f9074d06416
Author:     Ville Syrjälä <ville.syrjala at linux.intel.com>
AuthorDate: Mon Sep 1 18:08:25 2014 +0300
Commit:     Daniel Vetter <daniel.vetter at ffwll.ch>
CommitDate: Tue Sep 2 17:25:47 2014 +0200

    drm/i915: Don't call intel_plane_restore() when the prop value didn't
change

    No point in calling intel_plane_restore() in .set_property() if the
    value didn't change.

    More importantly this papers over a bug where the current primary plane
    code forgets to update the user coordinates we store under intel_plane
    unless the primary plane .update_plane() hook is actually called. This
    means we have 0 in the coordinates straight after boot and any call
    to intel_restore_plane() (such as from restore_fbdev_mode()) will
    actually turn off the primary plane. This mess needs to be fixed properly
    but that's a bigger task and the first step there is killing off
    intel_pipe_set_base() and just calling the primary plane
    .update_plane() hook. For the immediate problem of black screen after
    boot this small patch is enough to hide it.

    The problem originates from these two commits:
     commit 3a5f87c286515c54ff5c52c3e64d0c522b7570c0
     Author: Thomas Wood <thomas.wood at intel.com>
     Date:   Wed Aug 20 14:45:00 2014 +0100

        drm: fix plane rotation when restoring fbdev configuration

     commit d91a2cb8e5104233c02bbde539bd4ee455ec12ac
     Author: Sonika Jindal <sonika.jindal at intel.com>
     Date:   Fri Aug 22 14:06:04 2014 +0530

        drm/i915: Add 180 degree primary plane rotation support

    Cc: Thomas Wood <thomas.wood at intel.com>
    Cc: Sonika Jindal <sonika.jindal at intel.com>
    Tested-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
    Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
    Tested-by: Alan Stern <stern at rowland.harvard.edu>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140909/f5cbbe7e/attachment-0001.html>