[Bug 90248] New: [BSW Bisected] GpuTest triangle-windows case performance decrease on latest kernel
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Apr 30 00:07:03 PDT 2015
https://bugs.freedesktop.org/show_bug.cgi?id=90248
Bug ID: 90248
Summary: [BSW Bisected] GpuTest triangle-windows case
performance decrease on latest kernel
Product: DRI
Version: DRI git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: DRM/Intel
Assignee: intel-gfx-bugs at lists.freedesktop.org
Reporter: hengx.ding at intel.com
QA Contact: intel-gfx-bugs at lists.freedesktop.org
CC: intel-gfx-bugs at lists.freedesktop.org
Created attachment 115467
--> https://bugs.freedesktop.org/attachment.cgi?id=115467&action=edit
dmesg
System Environment:
--------------------------
Regression: yes
Platform: BSW
kernel: drm-inte-next-queued:
de4de566f84b87f4d5f8265b11932088adb19896(2015-04-29)
Bisect result
0875546c5318c85c13d07014af5350e9000bc9e9 is the first bad commit
commit 0875546c5318c85c13d07014af5350e9000bc9e9
Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date: Mon Apr 20 09:04:05 2015 -0700
drm/i915: Fix up the vma aliasing ppgtt binding
Currently we have the problem that the decision whether ptes need to
be (re)written is splattered all over the codebase. Move all that into
i915_vma_bind. This needs a few changes:
- Just reuse the PIN_* flags for i915_vma_bind and do the conversion
to vma->bound in there to avoid duplicating the conversion code all
over.
- We need to make binding for EXECBUF (i.e. pick aliasing ppgtt if
around) explicit, add PIN_USER for that.
- Two callers want to update ptes, give them a PIN_UPDATE for that.
Of course we still want to avoid double-binding, but that should be
taken care of:
- A ppgtt vma will only ever see PIN_USER, so no issue with
double-binding.
- A ggtt vma with aliasing ppgtt needs both types of binding, and we
track that properly now.
- A ggtt vma without aliasing ppgtt could be bound twice. In the
lower-level ->bind_vma functions hence unconditionally set
GLOBAL_BIND when writing the ggtt ptes.
There's still a bit room for cleanup, but that's for follow-up
patches.
v2: Fixup fumbles.
v3: s/PIN_EXECBUF/PIN_USER/ for clearer meaning, suggested by Chris.
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
:040000 040000 5d52d149dfbafae0fbc4869992352b596c4c6af5
37c3febcf1c8cd1da506717e6a6801ebdc625f64 M driversBug
detailed description:
-----------------------------
GpuTest triangle-windows performance decreased by about 10%-15%
Reproduce steps:
---------------------------
run GpuTest triangle-windows case and check the performance difference.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20150430/2d9f72b9/attachment.html>
More information about the intel-gfx-bugs
mailing list