[Bug 91467] SIGSEGV "get_fb: failed to add fb" / sna_block_handler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91467

--- Comment #17 from Chris Wilson <chris at chris-wilson.co.uk> ---
(In reply to Andreas Reis from comment #16)
> Created attachment 117387 [details]
> Xorg.0.log with sna: Add a small pixmap sanity check
> 
> With sna: Add a small pixmap sanity check the server won't even start as it
> instantly segfaults.

Oops,

commit d11dc75fb5a95ba410fedd86d9e1dd50260af979
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Sun Jul 26 19:07:45 2015 +0100

    sna: Only check non-NULL Pixmaps

    check_pixmap() can be called very early in the Window setup proceeding,
    before a pixmap is even assigned to a Window. There we expect the Window
    to be NULL, so be more careful in our check_pixmap.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91467#c16
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>


I think I understand the freeze,
commit e5f8f90f686879950766babbe805cd9d2412aca3
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Sun Jul 26 19:03:46 2015 +0100

    sna: Stall for outstanding TearFree flips when taking over with Present

    When juggling Present and TearFree, we have to hide the extra flips from
    Present as it cannot account for them. Preferrably we want to schedule
    the Present flip following completion of the TearFree flip, but for the
    moment simply block and wait until TearFree completes before starting
    Present.

    Reported-by: Andreas Reis <andreas.reis at gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91467
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

should prevent the freeze at the cost of a small stall everytime Present stops
and restarts flipping.

However, not convinced if that is related to the earlier crash - for which as
you can tell I've added some more debugging to hopefully catch in action.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20150726/d8d09eff/attachment.html>