[Bug 95301] On boot to console get trace on i915 module load
bugzilla-daemon at bugzilla.kernel.org
bugzilla-daemon at bugzilla.kernel.org
Wed Mar 25 14:51:04 PDT 2015
https://bugzilla.kernel.org/show_bug.cgi?id=95301
--- Comment #2 from Ivan Bulatovic <combuster at archlinux.us> ---
Got it:
319c1d420a0b62d9dbb88104afebaabc968cdbfa is the first bad commit
commit 319c1d420a0b62d9dbb88104afebaabc968cdbfa
Author: Xi Ruoyao <xry111 at outlook.com>
Date: Thu Mar 12 20:16:32 2015 +0800
drm/i915: Ensure plane->state->fb stays in sync with plane->fb
plane->state->fb and plane->fb should always reference the same FB so
that atomic and legacy codepaths have the same view of display state.
However, there are some places in kernel code that directly set
plane->fb and neglect to update plane->state->fb. If we never do a
successful update through the atomic pipeline, the RmFB cleanup code
will look at the plane->state->fb pointer, which has never actually
been set to a legitimate value, and try to clean it up, leading to
BUG's.
Add a quick helper function to synchronize plane->state->fb with
plane->fb and call it everywhere the driver tries to manually set
plane->fb outside of the atomic pipeline. In this function, use
drm_atomic_set_fb_for_plane instead of writing plane->state->fb
directly to keep the reference count right.
This is modified from Matt Roper's patch to drm-intel-nightly with
commit id
commit afd65eb4cc0578a9c07d621acdb8a570e2782bf7
Author: Matt Roper <matthew.d.roper at intel.com>
Date: Tue Feb 3 13:10:04 2015 -0800
drm/i915: Ensure plane->state->fb stays in sync with plane->fb
However this bug exists in mainline kernel too, so I created this to fix
it in mainline kernel.
A minor change is to use drm_atomic_set_fb_for_plane instead of update
reference count manually.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88909
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93711
Signed-off-by: Xi Ruoyao <xry111 at outlook.com>
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
[Jani: included the patch notes in the commit message]
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
:040000 040000 baa4beae6b27f959570b3507f3c1237c6d9181bf
d451c8e6ea1e02fc7779518c90c9d87a14786a39 M drivers
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the intel-gfx-bugs
mailing list