[Bug 92768] [BXT-P] [IGT Basic] pm_rps / basic-api fails

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 11 07:43:38 PST 2015


https://bugs.freedesktop.org/show_bug.cgi?id=92768

Imre Deak <imre.deak at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #4 from Imre Deak <imre.deak at intel.com> ---
Could you test if the following fixes the basic-api subtest?:

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index e9d85b8..ea1ad4e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7139,7 +7139,8 @@ static int chv_freq_opcode(struct drm_i915_private
*dev_priv, int val)
 int intel_gpu_freq(struct drm_i915_private *dev_priv, int val)
 {
     if (IS_GEN9(dev_priv->dev))
-        return (val * GT_FREQUENCY_MULTIPLIER) / GEN9_FREQ_SCALER;
+        return DIV_ROUND_CLOSEST(val * GT_FREQUENCY_MULTIPLIER,
+                     GEN9_FREQ_SCALER);
     else if (IS_CHERRYVIEW(dev_priv->dev))
         return chv_gpu_freq(dev_priv, val);
     else if (IS_VALLEYVIEW(dev_priv->dev))
@@ -7151,13 +7152,14 @@ int intel_gpu_freq(struct drm_i915_private *dev_priv,
int val)
 int intel_freq_opcode(struct drm_i915_private *dev_priv, int val)
 {
     if (IS_GEN9(dev_priv->dev))
-        return (val * GEN9_FREQ_SCALER) / GT_FREQUENCY_MULTIPLIER;
+        return DIV_ROUND_CLOSEST(val * GEN9_FREQ_SCALER,
+                     GT_FREQUENCY_MULTIPLIER);
     else if (IS_CHERRYVIEW(dev_priv->dev))
         return chv_freq_opcode(dev_priv, val);
     else if (IS_VALLEYVIEW(dev_priv->dev))
         return byt_freq_opcode(dev_priv, val);
     else
-        return val / GT_FREQUENCY_MULTIPLIER;
+        return DIV_ROUND_CLOSEST(val, GT_FREQUENCY_MULTIPLIER);
 }

 struct request_boost {

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20151111/9185070e/attachment.html>


More information about the intel-gfx-bugs mailing list