[Bug 95091] Pixelated shadow in Compiz

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Apr 23 22:04:25 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=95091

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
I put a cap in so that the shadow doesn't become too pixellated:

commit bca4e0e35e4ac27f2dcd1a8e5fcbf7ce69cec358
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Sat Apr 23 21:42:12 2016 +0100

    sna: Limit generic convolution to smallish kernels

    Since the naive implementation uses an 8bit temporary, we can only
    support so many passes before the quantization artefacts become
    apparent. We have to be extra conservation in order to support
    multi-pass convolution algorithms (notable 2-pass separable Gaussian
    kernels).

    References: https://bugs.freedesktop.org/show_bug.cgi?id=95091
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

It's a tradeoff that hopefully should allow small drop shadows (~15 pixels) to
be naively acceleration without looking atrocious.

It would be possible to fully support convolution kernels on recent hardware,
might be an interesting challenge.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160423/99828381/attachment.html>


More information about the intel-gfx-bugs mailing list