[Bug 93699] [BAT BDW] sporadic WARNING: "Device suspended during HW access" during kms_pipe_crc_basic on pipe B/C

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93699

--- Comment #1 from Ville Syrjala <ville.syrjala at linux.intel.com> ---
I'd say it's the same problem as in bug #93698, namely that the modeset path
calls intel_pre_plane_update() somewhat unconditionally. A quick glance
suggests that we should just:

--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13831,9 +13831,8 @@ static int intel_atomic_commit(struct drm_device *dev,
                if (!needs_modeset(crtc->state))
                        continue;

-               intel_pre_plane_update(intel_crtc);
-
                if (crtc_state->active) {
+                       intel_pre_plane_update(intel_crtc);
                        intel_crtc_disable_planes(crtc,
crtc_state->plane_mask);
                        dev_priv->display.crtc_disable(crtc);
                        intel_crtc->active = false;
@@ -13885,12 +13884,12 @@ static int intel_atomic_commit(struct drm_device
*dev,
                        hw_check = true;
                }

-               if (!modeset)
-                       intel_pre_plane_update(intel_crtc);
-
                if (crtc->state->active &&
-                   (crtc->state->planes_changed || update_pipe))
+                   (crtc->state->planes_changed || update_pipe)) {
+                       if (!modeset)
+                               intel_pre_plane_update(intel_crtc);
                        drm_atomic_helper_commit_planes_on_crtc(crtc_state);
+               }

                if (put_domains)
                        modeset_put_power_domains(dev_priv, put_domains);

but it's bit of mess all around so it's hard to be sure without more digging.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160113/d21824ab/attachment.html>