[Bug 92805] [BXT-P APL] [Audio] Cannot refresh ELD information on the text mode and the UI mode[

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92805

Jim Bride <jim.bride at linux.intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #12 from Jim Bride <jim.bride at linux.intel.com> ---
After taking a look at this, I'm pretty convinced that this is a bug in the
audio driver, particularly since cat /proc/asound/card0/eld#2.0 is pointing at
audio driver state.  After taking a peek at the hda driver code I found a place
where the audio driver is not updating its internal ELD state when it fails to
read the ELD from the i915 (via snd_hdac_acomp_get_eld(), which calls into
i915.)  I believe the hda driver  should, in any case where a failure to read
the ELD occurs, flag the cached ELD as invalid.  I'm going to test with the
patch below and see if it restores sanity.

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 426a29a..0c48909 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1667,8 +1667,6 @@ static void sync_eld_via_acomp(struct hda_codec *codec,
        size = snd_hdac_acomp_get_eld(&codec->bus->core, per_pin->pin_nid,
                                      &eld->monitor_present, eld->eld_buffer,
                                      ELD_MAX_SIZE);
-       if (size < 0)
-               goto unlock;
        if (size > 0) {
                size = min(size, ELD_MAX_SIZE);
                if (snd_hdmi_parse_eld(codec, &eld->info,
@@ -1687,7 +1685,6 @@ static void sync_eld_via_acomp(struct hda_codec *codec,
        update_eld(codec, per_pin, eld);
        snd_jack_report(per_pin->acomp_jack,
                        eld->monitor_present ? SND_JACK_AVOUT : 0);
- unlock:
        mutex_unlock(&per_pin->lock);
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160129/a8db966f/attachment.html>