[Bug 96915] [APL] too many voltage retries / CPU pipe X FIFO underrun / audio errors when suspending to ram

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 22 16:27:16 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=96915

Imre Deak <imre.deak at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
           Assignee|intel-gfx-bugs at lists.freede |imre.deak at intel.com
                   |sktop.org                   |

--- Comment #3 from Imre Deak <imre.deak at intel.com> ---
Could you try the following:

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 78beb7e..3c0c2d6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13682,12 +13682,14 @@ static void intel_atomic_commit_tail(struct
drm_atomic_state *state)
                         */
                        intel_check_cpu_fifo_underruns(dev_priv);
                        intel_check_pch_fifo_underruns(dev_priv);
-
-                       if (!crtc->state->active)
-                               intel_update_watermarks(crtc);
                }
        }

+       for_each_crtc_in_state(state, crtc, old_crtc_state, i) {
+               if (needs_modeset(crtc->state) && !crtc->state->active)
+                       intel_update_watermarks(crtc);
+       }
+
        /* Only after disabling all output pipelines that will be changed can
we
         * update the the output configuration. */
        intel_modeset_update_crtc_state(state);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160722/3cfe1899/attachment.html>


More information about the intel-gfx-bugs mailing list