[Bug 93580] intel_fbdev_restore_mode derefence null pointer

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jun 20 23:23:50 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=93580

--- Comment #7 from Kim Lidström <dxtr at emacs.church> ---
Is it possible to get patch https://patchwork.freedesktop.org/patch/93560/ and
https://patchwork.freedesktop.org/patch/93561/ that you gavae me in #96554 for
4.7-rc4?

They don't apply cleanly there.

This is the rejected hunk:

--- drivers/gpu/drm/i915/intel_fbdev.c
+++ drivers/gpu/drm/i915/intel_fbdev.c
@@ -551,12 +550,14 @@ static void intel_fbdev_destroy(struct drm_device *dev,
        drm_fb_helper_fini(&ifbdev->helper);

        if (ifbdev->fb) {
-               mutex_lock(&dev->struct_mutex);
+               mutex_lock(&ifbdev->helper.dev->struct_mutex);
                intel_unpin_fb_obj(&ifbdev->fb->base, BIT(DRM_ROTATE_0));
-               mutex_unlock(&dev->struct_mutex);
+               mutex_unlock(&ifbdev->helper.dev->struct_mutex);

                drm_framebuffer_remove(&ifbdev->fb->base);
        }
+
+       kfree(ifbdev);
 }

 /

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160620/0f29bc77/attachment.html>


More information about the intel-gfx-bugs mailing list