[Bug 70461] [sna suse] ddx assertion hits

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70461

--- Comment #132 from Chris Wilson <chris at chris-wilson.co.uk> ---
If we move the skip-on-stale check ahead of the assert, does that paper over
the bug?

diff --git a/src/sna/sna_dri2.c b/src/sna/sna_dri2.c
index 2ed698d..4b6fdad 100644
--- a/src/sna/sna_dri2.c
+++ b/src/sna/sna_dri2.c
@@ -3302,15 +3302,15 @@ sna_dri2_schedule_swap(ClientPtr client, DrawablePtr
draw, DRI2BufferPtr front,
        assert(get_private(front)->refcnt);
        assert(get_private(back)->refcnt);

-       assert(get_private(back)->bo != get_private(front)->bo);
-       assert(get_private(front)->bo->refcnt);
-       assert(get_private(back)->bo->refcnt);
-
        if (get_private(back)->stale) {
                DBG(("%s: stale back buffer\n", __FUNCTION__));
                goto skip;
        }

+       assert(get_private(back)->bo != get_private(front)->bo);
+       assert(get_private(front)->bo->refcnt);
+       assert(get_private(back)->bo->refcnt);
+
        if (draw->type != DRAWABLE_PIXMAP) {
                WindowPtr win = (WindowPtr)draw;
                struct dri2_window *priv = dri2_window(win);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160314/cdd2b0e3/attachment.html>