[Bug 98040] [BAT][BYT] kms_pipe_crc_basic at suspend-read-crc-pipe-a *ERROR* dp_aux_ch not done status 0x00050000

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 7 14:26:38 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=98040

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
One hole is that we disable drm_kms_helper before we turn off the hpd init_work
- that is the init_work can fire and re-enable the drm_kms_helper during
suspend.

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 89d322215c84..7bb08c503f75 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1416,8 +1416,6 @@ static int i915_drm_suspend(struct drm_device *dev)
         * properly. */
        intel_display_set_init_power(dev_priv, true);

-       drm_kms_helper_poll_disable(dev);
-
        pci_save_state(pdev);

        error = i915_gem_suspend(dev);
@@ -1430,11 +1428,12 @@ static int i915_drm_suspend(struct drm_device *dev)
        intel_guc_suspend(dev);

        intel_display_suspend(dev);
-
        intel_dp_mst_suspend(dev);

        intel_runtime_pm_disable_interrupts(dev_priv);
+
        intel_hpd_cancel_work(dev_priv);
+       drm_kms_helper_poll_disable(dev);

        intel_suspend_encoders(dev_priv);

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20161007/858bb62a/attachment.html>


More information about the intel-gfx-bugs mailing list