[Bug 101838] [BAT][ELK] The machine fails to resume after 4.13-rc1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101838

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #12 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 4b1cd3afb1c7e918c3e0748dfd4ecb6e43a41573
Author: Thomas Gleixner <tglx at linutronix.de>
Date:   Mon Jul 31 22:07:09 2017 +0200

    x86/hpet: Cure interface abuse in the resume path

    The HPET resume path abuses irq_domain_[de]activate_irq() to restore the
    MSI message in the HPET chip for the boot CPU on resume and it relies on an
    implementation detail of the interrupt core code, which magically makes the
    HPET unmask call invoked via a irq_disable/enable pair. This worked as long
    as the irq code did unconditionally invoke the unmask() callback. With the
    recent changes which keep track of the masked state to avoid expensive
    hardware access, this does not longer work. As a consequence the HPET timer
    interrupts are not unmasked which breaks resume as the boot CPU waits
    forever that a timer interrupt arrives.

    Make the restore of the MSI message explicit and invoke the unmask()
    function directly. While at it get rid of the pointless affinity setting as
    nothing can change the affinity of the interrupt and the vector across
    suspend/resume. The restore of the MSI message reestablishes the previous
    affinity setting which is the correct one.

    Fixes: bf22ff45bed6 ("genirq: Avoid unnecessary low level irq function
calls")
    Reported-by: Martin Peres <martin.peres at linux.intel.com>
    Reported-by: Tomi Sarvela <tomi.p.sarvela at intel.com>
    Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
    Cc: jeffy.chen at rock-chips.com
    Cc: Marc Zyngier <marc.zyngier at arm.com>
    Cc: Peter Ziljstra <peterz at infradead.org>
    Cc: "Rafael J. Wysocki" <rafael.j.wysocki at intel.com>
    Tested-by: Tomi Sarvela <tomi.p.sarvela at intel.com>


Applied to core-for-CI and presumed going upstream urgently.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170801/28de2778/attachment.html>