[Bug 101852] [BAT][GDG] igt at drv_hangman@error-state-basic incomplete in CI

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101852

--- Comment #9 from Chris Wilson <chris at chris-wilson.co.uk> ---
After a third round of bisecting with manual patching:

bd18728a3f2edee33d4d241d20f394c798fb414 is the first bad commit
commit 9bd18728a3f2edee33d4d241d20f394c798fb414
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date:   Fri May 13 10:10:42 2016 -0700

    drm/i915: Ignore stale wm register values on resume on ilk-bdw (v2)

    When we resume the watermark register may contain some BIOS leftovers,
    or just the hardware reset values. We should ignore those as the
    pipes will be off anyway, and so frobbing around with intermediate
    watermarks doesn't make much sense.

    In fact I think we should just throw the skip_intermediate_wm flag
    out, and instead properly sanitize the "active" watermarks to match
    the current plane and pipe states. The actual wm state readout might
    also need a bit of work. But for now, let's continue with the
    skip_intermediate_wm to keep the fix more minimal.

    Fixes this sort of errors on resume
    [drm:ilk_validate_pipe_wm] LP0 watermark invalid
    [drm:intel_crtc_atomic_check] No valid intermediate pipe watermarks are
possible
    [drm:intel_display_resume [i915]] *ERROR* Restoring old state failed with
-22
    and a boatload of subsequent modeset BAT fails on my ILK.

    v2:
     - Rebase; the SKL atomic WM patches that just landed changed the WM
       structure fields in intel_crtc_state slightly.  (Matt)

    Cc: Matt Roper <matthew.d.roper at intel.com>
    Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
    Fixes: ed4a6a7ca853 ("drm/i915: Add two-stage ILK-style watermark
programming (v11)")
    Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
    Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
    Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
    Link:
http://patchwork.freedesktop.org/patch/msgid/1463159442-20478-1-git-send-email-matthew.d.roper@intel.com
    (cherry picked from commit e3d5457c7caabb77b3f1d0b09c4a63362e9b04d2)
    [Jani: rebase on drm-next while cherry-picking]
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>


Now starting to double check.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170810/bf11795e/attachment.html>