[Bug 103514] [BAT] [GLK-DSI only] igt at gem_* - Failed assertion: !"GPU hung" - and its aftermath

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Dec 13 12:53:01 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103514

--- Comment #33 from Chris Wilson <chris at chris-wilson.co.uk> ---
One random memcorruption issue fixed:

commit 7d622351c94172a42bfe9b13bdb0fdc2be90ed3b
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Dec 13 09:48:02 2017 +0000

    drm/i915/fence: Use rcu to defer freeing of irq_work

    It is illegal to perform an immediate free of the struct irq_work from
    inside the irq_work callback (as irq_work_run_list modifies work->flags
    after execution of the work->func()). As we use the irq_work to
    coordinate the freeing of the callback from two different softirq paths,
    we need to defer the kfree from inside our irq_work callback, for which
    we can use kfree_rcu.

    Fixes: 81c0ed21aa91 ("drm/i915/fence: Avoid del_timer_sync() from inside a
timer")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20171213094802.28243-1-chris@chris-wilson.co.uk

Hopefully this explains a lot of weirdness.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20171213/1ee7e686/attachment.html>


More information about the intel-gfx-bugs mailing list