[Bug 99833] New: src/backlight.c only defines __backlight_exists one branch of #ifdef HAVE_DEV_WSCONS_WSCONSIO_H

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99833

            Bug ID: 99833
           Summary: src/backlight.c only defines __backlight_exists one
                    branch of #ifdef HAVE_DEV_WSCONS_WSCONSIO_H
           Product: xorg
           Version: git
          Hardware: x86-64 (AMD64)
                OS: NetBSD
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/intel
          Assignee: chris at chris-wilson.co.uk
          Reporter: davshao at gmail.com
        QA Contact: intel-gfx-bugs at lists.freedesktop.org

Created attachment 129660
  --> https://bugs.freedesktop.org/attachment.cgi?id=129660&action=edit
Patch to restore previous use of backlight_exists

commit  b24e7581bd1e5a0215cb73ec87093ebf03c20278
"backlight: Factor known names into preferred interfaces"
from 2015-06-17
defines in project xf86-video-intel, file src/backlight.c,

static int __backlight_exists(const char *iface)

only in one half, the #else branch, of
#ifdef HAVE_DEV_WSCONS_WSCONSIO_H
Then function __backlight_exists() is used after the #endif in

char *backlight_find_for_device(struct pci_device *pci)

This problem was detected using pkgsrc-wip xf86-video-intel
on current NetBSD amd64, which uses a git snapshot of xf86-video-intel.

Attached is a patch that replaces the use of __backlight_exists
with the previously used function backlight_exists().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170216/9fd5b18c/attachment.html>