[Bug 100011] src/intel_device.c reverses return value meaning of xorg server xf86LoadKernelModule()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Feb 28 20:53:17 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=100011

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 78d7a09b0343829c81257024b164b0b3764392ac
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Feb 28 20:48:43 2017 +0000

    intel: Fix checking xf86LoadKernelModule for success

    Originally introduced in

    commit f66e25def3431a900068cc1c23a6b1e8322ef046
    Author: Chris Wilson <chris at chris-wilson.co.uk>
    Date:   Mon Jun 23 16:14:28 2014 +0100

        intel: Wait for the DRM device to load

    the legacy path was checking the return xf86LoadKernelModule
    incorrectly. This error was then copy into the common loader in

    commit 6a2dcb388e6b549c3175ccfbcd3f1751e25de40a
    Author: Chris Wilson <chris at chris-wilson.co.uk>
    Date:   Fri Jul 31 10:40:32 2015 +0100

        intel: Refactor i915.ko loading support

    xf86LoadKernelModule() returns 1 on success and zero on failure.

    Reported-by: David Shao <davshao at gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100011
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170228/ae928bd1/attachment-0001.html>


More information about the intel-gfx-bugs mailing list