[Bug 101854] [IGT][BYT] Failure with sub tests gem_reloc_vs_gpu

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101854

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit edf9f2d31231c6ae2a4e621ef67c68758ddc447d
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Jul 21 15:50:36 2017 +0100

    drm/i915: Only skip updating execobject.offset after error

    I was being overly paranoid in not updating the execobject.offset after
    performing the fallback copy where we set reloc.presumed_offset to -1.
    The thinking was to ensure that a subsequent NORELOC execbuf would be
    forced to process the invalid relocations. However this is overkill so
    long as we *only* update the execobject.offset following a successful
    update of the relocation value witin the batch. If we have to repeat the
    execbuf due to a later interruption, then we may skip the relocations on
    the second pass (honouring NORELOC) since the execobject.offset match
    the actual offsets (even though reloc.presumed_offset is garbage).

    Subsequent calls to execbuf with NORELOC should themselves ensure that
    the reloc.presumed_offset have been corrected in case of future
    migration.

    Reporting back the actual execobject.offset, even when
    reloc.presumed_offset is garbage, ensures that reuse of those objects
    use the latest information to avoid relocations.

    Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the
execobjects array")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101635
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
    Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20170721145037.25105-4-chris@chris-wilson.co.uk
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170726/903f1fc1/attachment.html>