[Bug 101167] [BAT][SKL] igt at kms_flip@basic-flip-vs-dpms produces a dmesg-fail

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jun 5 08:31:52 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101167

--- Comment #12 from Marta Löfstedt <marta.lofstedt at intel.com> ---
I was wondering why we don't sleep when we are timed out on the aux channel.
So, I decided to test below:

--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -198,7 +198,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8
request,
         * sufficient, bump to 32 which makes Dell 4k monitors happier.
         */
        for (retry = 0; retry < 32; retry++) {
-               if (ret != 0 && ret != -ETIMEDOUT) {
+               if (ret != 0 /*&& ret != -ETIMEDOUT*/) {

To my surprise this does NOT help. 

Note:
 commit e1083ff35157185b01bc0a99cb19b7cbae0fc9fa
Author: Lyude <cpaul at redhat.com>
Date:   Wed Apr 13 10:58:30 2016 -0400

    drm/dp_helper: Always wait before retrying native aux transactions

There is also a reference to a discussion about a similar issue, but this time
with docking station involved for this patch:
commit 82922da39190199260a726d7081a8ea4873e5fd6
Author: Lyude <cpaul at redhat.com>
Date:   Wed Apr 13 10:58:31 2016 -0400

    drm/dp_helper: Retry aux transactions on all errors

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170605/44a692ad/attachment-0001.html>


More information about the intel-gfx-bugs mailing list