[Bug 101111] [Regression BDW] backlight flickering/display artifacting on Broadwell integrated graphics with 4.12-rc1

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat May 20 04:18:37 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101111

--- Comment #2 from Nicholas Stommel <nicholas.stommel at gmail.com> ---
Created attachment 131420
  --> https://bugs.freedesktop.org/attachment.cgi?id=131420&action=edit
The folllowing patch seems to fix the issue!

Ah, it was as I expected. The following patch appears to fix the issue! It
looks like these exact same lines from the previous bug I filed at
https://bugs.freedesktop.org/show_bug.cgi?id=97918 has come back to haunt us in
a weird way. But the fix seems to really work!

--- a/drivers/gpu/drm/i915/intel_opregion.c     2017-05-13 16:19:49.000000000
-0400
+++ b/drivers/gpu/drm/i915/intel_opregion.c     2017-05-19 22:44:29.891397327
-0400
@@ -1021,23 +1021,6 @@
        return err;
 }

-static int intel_use_opregion_panel_type_callback(const struct dmi_system_id
*id)
-{
-       DRM_INFO("Using panel type from OpRegion on %s\n", id->ident);
-       return 1;
-}
-
-static const struct dmi_system_id intel_use_opregion_panel_type[] = {
-       {
-               .callback = intel_use_opregion_panel_type_callback,
-               .ident = "Conrac GmbH IX45GM2",
-               .matches = {DMI_MATCH(DMI_SYS_VENDOR, "Conrac GmbH"),
-                           DMI_MATCH(DMI_PRODUCT_NAME, "IX45GM2"),
-               },
-       },
-       { }
-};
-
 int
 intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
 {
@@ -1063,15 +1046,5 @@
                return -ENODEV;
        }

-       /*
-        * So far we know that some machined must use it, others must not use
it.
-        * There doesn't seem to be any way to determine which way to go,
except
-        * via a quirk list :(
-        */
-       if (!dmi_check_system(intel_use_opregion_panel_type)) {
-               DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
-               return -ENODEV;
-       }
-
        return ret - 1;
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170520/0b3f41a7/attachment.html>


More information about the intel-gfx-bugs mailing list