[Bug 101243] New: Possible access to unintended variable in "linux/drivers/gpu/drm/i915/dvo_ch7xxx.c" line 234

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101243

            Bug ID: 101243
           Summary: Possible access to unintended variable in
                    "linux/drivers/gpu/drm/i915/dvo_ch7xxx.c" line 234
           Product: DRI
           Version: XOrg git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: minor
          Priority: medium
         Component: DRM/Intel
          Assignee: intel-gfx-bugs at lists.freedesktop.org
          Reporter: petrum at gmail.com
        QA Contact: intel-gfx-bugs at lists.freedesktop.org
                CC: intel-gfx-bugs at lists.freedesktop.org

While experimenting with a CodeSonar plugin we develop, we noticed a
potential issue in file "linux/drivers/gpu/drm/i915/dvo_ch7xxx.c" line 234
function ch7xxx_init

if (!ch7xxx_readb(dvo, CH7xxx_REG_DID, &device))
                goto out;

        devid = ch7xxx_get_did(device);
        if (!devid) {
                DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
                                "slave %d.\n",
        /*here*/          vendor, adapter->name, dvo->slave_addr);
                goto out;
}

Wasn't the intention to log the value of the "device" variable (instead of
"vendor")? The message indicates that the intention is to log the value got
from ch7xxx (in this case device). The vendor is logged in line 222.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20170531/05520354/attachment.html>