[Bug 105560] [CI] igt at gem_exec_suspend@basic-s3 - dmesg-warn - Delta way too big!

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105560

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> ---
On the second attempt:

commit eaf328ff6661fa9be7d3d2ea3a9dff2eeb91348e
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Mar 30 15:58:19 2018 +0100

    trace: Mention trace_clock=global when warning about unstable clocks

    Mention the alternative of adding trace_clock=global to the kernel
    command line when we detect that we've used an unstable clock across a
    suspend/resume cycle.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Steven Rostedt <rostedt at goodmis.org>
    ---
    Blessed-by: Steven Rostedt <rostedt at goodmis.org>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20180330150132.16903-2-chris@chris-wilson.co.uk

Upstream linux-trace.git:

commit 932066a153350b4af7350f4a9ccbc93a0b9cc86b
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Mar 30 16:01:31 2018 +0100

    tracing: Default to using trace_global_clock if sched_clock is unstable

    Across suspend, we may see a very large drift in timestamps if the sched
    clock is unstable, prompting the global trace's ringbuffer code to warn
    and suggest switching to the global clock. Preempt this request by
    detecting when the sched clock is unstable (determined during
    late_initcall) and automatically switching the default clock over to
    trace_global_clock.

+ fixup

    trace: Fixup logic inversion on setting trace_global_clock defaults

    In commit 932066a15335 ("tracing: Default to using trace_global_clock if
    sched_clock is unstable"), the logic for deciding to override the
    default clock if unstable was reversed from the earlier posting. I was
    trying to reduce the width of the message by using an early return
    rather than a if-block, but reverted back to using the if-block and
    accidentally left the predicate inverted.

    Fixes: 932066a15335 ("tracing: Default to using trace_global_clock if
sched_
clock is unstable")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Steven Rostedt (VMware) <rostedt at goodmis.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180404/69f2611b/attachment.html>