[Bug 94921] Remove illogical/bogus "Automatic" mode from "Broadcast RGB" property

bugzilla-daemon at bugzilla.kernel.org bugzilla-daemon at bugzilla.kernel.org
Fri Aug 3 22:23:15 UTC 2018


https://bugzilla.kernel.org/show_bug.cgi?id=94921

Rodrigo Vivi (rodrigo.vivi at gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rodrigo.vivi at gmail.com

--- Comment #20 from Rodrigo Vivi (rodrigo.vivi at gmail.com) ---
I checked the history here, and patches and spec and we (me and Paulo) spend
few times in some experiments here. So a few clarification is needed:

- i915 code follows spec. We are not changing that. The spec is the only thing
that is common here and we just have hope that all sinks and sources are
respecting the spec as the driver is. otherwise it gets messy so easily.
So yes, this should be religiously followed by everyone involved.
- DP spec is not "years old". I checked old and even new released DP-1.4 spec
and the recommendation is to respect "CTA (former CEA) range" when the mode is
a mode described by CTA-861-F (former CEA-861-F).
- Paulo, who review the initial "automatic" code is also suffering from the
automatic option. But on his case the best for him is the limited!!! So user
preference is needed here.
- i915 already provide the connector property that could be set per user need
in a atomic way. There is nothing special support for X. Wayland could
implement the support to toggle that option. We are not providing a connector
property throught sysfs. That is out of question. the broadcast range option is
a connector property and will stay as is. Option is Wayland to implement the
toggle support.

But no, I'm not closing the bug here as "wontfix" this time.

I believe that we have room for improvements on the color
space as documented on ilk_load_csc_matrix():

1. /* FIXME if there's a gamma LUT after the CSC, we should                     
    * do the range compression using the gamma LUT instead. */

and

2. /* TODO: Check what kind of values actually come out of the                  
    * pipe with these coeff/postoff values and adjust to get the                
    * best accuracy. Perhaps we even need to take the bpc value                 
    * into consideration.*/

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the intel-gfx-bugs mailing list