[Bug 107562] ThinkPad T450 - Broadwell-U: [drm:hsw_disable_ips [i915]] *ERROR* Timed out waiting for IPS disable

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107562

--- Comment #16 from Diego Viola <diego.viola at gmail.com> ---
(In reply to Imre Deak from comment #15)
> Hi Diego,
> 
> sounds like a timing issue. Could you try if you can reproduce the problem
> with the following patch?
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index ad0f0e5389d9..19c4b3ff691b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5081,7 +5081,7 @@ void hsw_disable_ips(const struct intel_crtc_state
> *crtc_state)
>  		/* wait for pcode to finish disabling IPS, which may take up to 42ms */
>  		if (intel_wait_for_register(dev_priv,
>  					    IPS_CTL, IPS_ENABLE, 0,
> -					    42))
> +					    100))
>  			DRM_ERROR("Timed out waiting for IPS disable\n");
>  	} else {
>  		I915_WRITE(IPS_CTL, 0);

Hi Imre,

Thanks for your patch. I am currently running drm-tip
(4.19.0-rc1-gfd1d65ac5-dirty) with your patch applied and so far so good, no
errors yet.

I'll run with this for the rest of the week before confirming, but for now all
is good.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180827/8786e04e/attachment.html>