[Bug 107111] "Avoid waitboosting" (e9af4ea2b9e7) now prevents GPU boosting

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107111

--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> ---
What it is telling us is that the GPU is never utilised enough for it to
upclock by itself -- Kodi should not need more power to deliver the frames on
time, and that boosting is overkill.

One thing to confirm is which boost Kodi is depending on. So try just reverting
the intel_display chunk so that it always boost after the vblank miss.

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 681e0710a467..0d4c61e53a6c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12913,7 +12913,8 @@ static int do_rps_boost(struct wait_queue_entry *_wait,
         * is reasonable to assume that it will complete before the next
         * vblank without our intervention, so leave RPS alone.
         */
-       if (!i915_request_started(rq))
+       if (!i915_request_started(rq) ||
+           rq != i915_gem_active_peek(&rq->timeline->last_request))
                gen6_rps_boost(rq, NULL);
        i915_request_put(rq);

might be an interesting compromise. But what I think is that we want is more of
a nudge.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180704/2e68fb33/attachment.html>